Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notebook editor focusing #14229

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

jonah-iden
Copy link
Contributor

What it does

This fixes the focussing of notebook editors when switching tabs.
Previously there was the problem that it was neccessary to click the notebook editor once to set it as active

How to test

Best is probably through debugging.
Set breakpoints in applicaiton-shell.ts at onCurrentChangedand onActiveChanged and click the tab of a currently hidden notebook editor.
It should now focus correctly

Follow-ups

Review checklist

Reminder for reviewers

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, do you mind adding a tabIndex here as well?

return <div className='theia-notebook-main-container'>

@msujew msujew added the notebook issues related to notebooks label Sep 30, 2024
@jonah-iden jonah-iden merged commit 1f5eb2b into master Sep 30, 2024
11 checks passed
@jonah-iden jonah-iden deleted the jiden/fix-notebook-editor-focusing branch September 30, 2024 09:27
@github-actions github-actions bot added this to the 1.55.0 milestone Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook issues related to notebooks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants