Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect import in split-widget.ts #14232

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

pisv
Copy link
Contributor

@pisv pisv commented Sep 29, 2024

What it does

Updates imports in split-widget.ts where Emitter was incorrectly imported from 'vscode-languageserver-protocol' instead of 'common'.

How to test

This is a trivial change, which is not expected to cause any regressions.

Review checklist

Reminder for reviewers

`Emitter` was incorrectly imported from 'vscode-languageserver-protocol'
instead of 'common'.
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew added the quality issues related to code and application quality label Sep 30, 2024
@msujew msujew merged commit 6d395f8 into eclipse-theia:master Sep 30, 2024
11 checks passed
@pisv pisv deleted the fix-incorrect-import branch September 30, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality issues related to code and application quality
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants