fix: do not reject unknown schemes in WindowStateExt.asExternalUri

Fixes eclipse-theia#12821
eclipsesource · Nov 6, 2023 · c341da0 · c341da0
1 parent f33547e
commit c341da0
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/plugin-ext/src/plugin/window-state.ts b/packages/plugin-ext/src/plugin/window-state.ts
@@ -50,16 +50,20 @@ export class WindowStateExtImpl implements WindowStateExt {
     }
 
     openUri(uri: URI): Promise<boolean> {
+        if (!uri.scheme.trim().length) {
+            throw new Error('Invalid scheme - cannot be empty');
+        }
+
+        if (Schemes.http !== uri.scheme && Schemes.https !== uri.scheme) {
+            throw new Error(`Invalid scheme '${uri.scheme}'`);
+        }
         return this.proxy.$openUri(uri);
     }
 
     async asExternalUri(target: URI): Promise<URI> {
         if (!target.scheme.trim().length) {
             throw new Error('Invalid scheme - cannot be empty');
         }
-        if (Schemes.http !== target.scheme && Schemes.https !== target.scheme) {
-            throw new Error(`Invalid scheme '${target.scheme}'`);
-        }
 
         const uri = await this.proxy.$asExternalUri(target);
         return URI.revive(uri);