Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint overhaul (pylint to ruff) #1

Merged
merged 22 commits into from
Mar 6, 2024
Merged

Lint overhaul (pylint to ruff) #1

merged 22 commits into from
Mar 6, 2024

Conversation

eginhard
Copy link
Owner

@eginhard eginhard commented Mar 6, 2024

Copied from coqui-ai#3004:

This PR looks a bit big, but it's pretty straightforward if you look at the commits in isolation.

Basically, it replaces pylint and isort with the ruff linter, and re-enables linting in CI (now that it's not screaming an awful lot – I hope @erogol has found some peace of mind (ref. 8c1d8df)). The pylint configuration was converted with ttps://github.com/akx/pylint-to-ruff.

* `pre-commit` is also updated, but currently running `pre-commit run --all-files` yields a ton of changes.

* Some ruff rules are _not_ enabled at this point at all because they're kind of noisy, but they could be enabled in future PRs one by one.

* This PR supersedes [Update pre-commit tools #2992](https://github.com/coqui-ai/TTS/pull/2992).

* I found [[Bug] compute_attention_masks.py doesn't work #3002](https://github.com/coqui-ai/TTS/issues/3002) while working on this, so hey, there's clearly a point to this.

Additionally removed isort and updated to latest version of ruff.

@eginhard
Copy link
Owner Author

eginhard commented Mar 6, 2024

Lint check fails here, but works locally. Let's see how it goes...

@eginhard eginhard merged commit 24298da into dev Mar 6, 2024
47 of 49 checks passed
@eginhard eginhard deleted the lint-overhaul branch March 6, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants