Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add navigation-history to examples sections on sidebar #651

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alicelovescake
Copy link
Contributor

This PR:

@alicelovescake alicelovescake requested a review from a team as a code owner September 23, 2024 21:27
@ckerr
Copy link
Member

ckerr commented Sep 24, 2024

I wonder what's going on with the Cloudfire Pages check hanging.

@MarshallOfSound
Copy link
Member

The build is failing 🤷


14:27:19.573 | - latest/tutorial/windows-taskbar
-- | --
14:27:19.573 |  
14:27:19.573 | at Object.checkSidebarsDocIds (/opt/buildhome/repo/node_modules/@docusaurus/plugin-content-docs/lib/sidebars/utils.js:245:19)
14:27:19.573 | at doLoadVersion (/opt/buildhome/repo/node_modules/@docusaurus/plugin-content-docs/lib/index.js:146:31)
14:27:19.573 | at async loadVersion (/opt/buildhome/repo/node_modules/@docusaurus/plugin-content-docs/lib/index.js:163:28)
14:27:19.573 | at async Promise.all (index 0)
14:27:19.573 | at async Object.loadContent (/opt/buildhome/repo/node_modules/@docusaurus/plugin-content-docs/lib/index.js:171:33)
14:27:19.573 | at async /opt/buildhome/repo/node_modules/@docusaurus/core/lib/server/plugins/plugins.js:39:23
14:27:19.573 | at async Promise.all (index 0)
14:27:19.573 | at async /opt/buildhome/repo/node_modules/@docusaurus/core/lib/server/plugins/plugins.js:140:25
14:27:19.573 | at async loadSite (/opt/buildhome/repo/node_modules/@docusaurus/core/lib/server/site.js:137:45)
14:27:19.574 | at async buildLocale (/opt/buildhome/repo/node_modules/@docusaurus/core/lib/commands/build.js:105:18)
14:27:19.574 | at async tryToBuildLocale (/opt/buildhome/repo/node_modules/@docusaurus/core/lib/commands/build.js:47:13)
14:27:19.574 | at async /opt/buildhome/repo/node_modules/@docusaurus/core/lib/commands/build.js:65:9
14:27:19.574 | at async mapAsyncSequential (/opt/buildhome/repo/node_modules/@docusaurus/utils/lib/jsUtils.js:21:24)
14:27:19.574 | at async Command.build (/opt/buildhome/repo/node_modules/@docusaurus/core/lib/commands/build.js:63:5)
14:27:19.574 | }


@erickzhao
Copy link
Member

erickzhao commented Sep 24, 2024

The build is failing due to:

  1. A missing backport to 32-x-y (docs: navigation history example electron#42980)
  2. The updater bot not passing repo checks and the content not actually being updated: https://github.com/electron/website/actions/runs/10999832814 (We can pull in the data manually for now, but this needs to be reset by an admin).

@erickzhao
Copy link
Member

Looks like we decided intentionally to not backport the contents of the PR to 32-x-y: electron/electron#43889 (review)

I think it's valid to mark this as draft and wait for Electron 33 to land before adding this to the website :)

@erickzhao erickzhao marked this pull request as draft September 24, 2024 17:47
@alicelovescake
Copy link
Contributor Author

Looks like we decided intentionally to not backport the contents of the PR to 32-x-y: electron/electron#43889 (review)

I think it's valid to mark this as draft and wait for Electron 33 to land before adding this to the website :)

Ahh thanks Erick!! My bad for losing track of the releases. Thanks for the call out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants