Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Resolve Protocol.UndefinedError by using fallback #287

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

OldhamMade
Copy link
Contributor

@OldhamMade OldhamMade commented Feb 26, 2024

Fixes an issue where :requests is nil but the following lines expect an empty list.

This was a quick fix for my own project, so I haven't put together any tests yet. However, all current tests pass locally.

mix.exs Outdated Show resolved Hide resolved
Copy link
Collaborator

@oltarasenko oltarasenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase your commit and remove changes to mix.exs, so I can merge the code

@OldhamMade
Copy link
Contributor Author

Done!

@oltarasenko oltarasenko self-requested a review April 24, 2024 13:08
@oltarasenko oltarasenko merged commit 2a6908f into elixir-crawly:master Apr 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants