-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take the RobotsTxt User-Agent from the Request #294
Merged
oltarasenko
merged 10 commits into
elixir-crawly:master
from
adonig:robotstxt-user-agent
Apr 29, 2024
Merged
Take the RobotsTxt User-Agent from the Request #294
oltarasenko
merged 10 commits into
elixir-crawly:master
from
adonig:robotstxt-user-agent
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe there's a way to squash all those commits into one 😅 |
oltarasenko
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could I ask you to add a test to the code, so I can merge it.
Do you believe this test is sufficient? test "Respects the User-Agent header when evaluating robots.txt" do
:meck.expect(Gollum, :crawlable?, fn
"My Custom Bot", _url -> :crawlable
_ua, _url -> :uncrawlable
end)
middlewares = [
{Crawly.Middlewares.UserAgent, user_agents: ["My Custom Bot"]},
Crawly.Middlewares.RobotsTxt
]
req = @valid
state = %{spider_name: :test_spider, crawl_id: "123"}
assert {%Crawly.Request{}, _state} =
Crawly.Utils.pipe(middlewares, req, state)
middlewares = [Crawly.Middlewares.RobotsTxt]
assert {false, _state} = Crawly.Utils.pipe(middlewares, req, state)
end |
oltarasenko
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the RobotsTxt middleware to dynamically use the User-Agent from each request instead of relying on a hardcoded value. It supersedes an earlier attempt, ensuring that the changes merge cleanly without the previous issues.