Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Crawly.fetch/2 function #306

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Simplify Crawly.fetch/2 function #306

merged 1 commit into from
Aug 29, 2024

Conversation

oltarasenko
Copy link
Collaborator

I decided to refactor this code a bit, so it is more simple (and also credo was complaining about it). Hopefully Ziink will forgive me :)

I decided to refactor this code a bit, so it is more simple (and also
credo was complaining about it). Hopefully Ziink will forgive me :)
Copy link

github-actions bot commented Aug 29, 2024

Tests summary

Finished in 11.7 seconds (0.7s async, 11.0s sync)
Randomized with seed 881356

0 failures (135 tests)
76.36% coverage (75% is the minimum)

Coverage details
Percentage | Module
-----------|--------------------------
     0.00% | Crawly.Fetchers.Splash
     0.00% | Crawly.Loggers.SendToUiBackend
     0.00% | Crawly.Response
     0.00% | Mix.Tasks.Crawly.Gen.Config
     0.00% | String.Chars.Crawly.Request
     0.00% | UtilsTestSpider
    40.00% | PipelineTestSpider
    42.86% | TestSpider
    53.85% | Mix.Tasks.Crawly.Gen.Spider
    60.67% | Crawly.API.Router
    61.54% | Crawly.Models.YMLSpider
    66.67% | Crawly.Models.Job
    68.42% | Crawly
    75.00% | Crawly.Pipelines.JSONEncoder
    76.47% | Crawly.SimpleStorage
    76.92% | Crawly.Fetchers.CrawlyRenderServer
    77.78% | Crawly.Pipelines.Experimental.SendToUI
    80.00% | Crawly.EngineSup
    82.61% | Crawly.Pipelines.WriteToFile
    83.33% | Crawly.Middlewares.UserAgent
    84.54% | Crawly.Utils
    86.84% | Crawly.Engine
    87.50% | Crawly.Application
    87.50% | TestUtils
    88.37% | Crawly.RequestsStorage
    88.46% | Crawly.RequestsStorage.Worker
    89.06% | Crawly.Manager
    90.00% | Crawly.Pipelines.Validate
    91.84% | Crawly.Worker
    92.11% | Crawly.DataStorage
    92.86% | Crawly.DataStorage.Worker
   100.00% | Crawly.Fetchers.Fetcher
   100.00% | Crawly.Fetchers.HTTPoisonFetcher
   100.00% | Crawly.ManagerSup
   100.00% | Crawly.Middlewares.AutoCookiesManager
   100.00% | Crawly.Middlewares.DomainFilter
   100.00% | Crawly.Middlewares.RequestOptions
   100.00% | Crawly.Middlewares.RobotsTxt
   100.00% | Crawly.Middlewares.SameDomainFilter
   100.00% | Crawly.Middlewares.UniqueRequest
   100.00% | Crawly.ParsedItem
   100.00% | Crawly.Pipeline
   100.00% | Crawly.Pipelines.CSVEncoder
   100.00% | Crawly.Pipelines.DuplicatesFilter
   100.00% | Crawly.Request
   100.00% | Crawly.Settings
   100.00% | Crawly.Spider
-----------|--------------------------
    76.36% | Total

@oltarasenko oltarasenko merged commit 0f7a583 into master Aug 29, 2024
1 check passed
@oltarasenko oltarasenko deleted the impr branch August 29, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant