Avoid requiring EXIT_RUNTIME when running threaded programs under node #22445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
sbc100
force-pushed
the
pthread_exit_handling
branch
2 times, most recently
from
c8aa2b7
to
1507300
Compare
kripken
approved these changes
Aug 26, 2024
| @@ -582,6 +582,7 @@ var LibraryPThread = { | |||
| #if PTHREADS_DEBUG | |||
| dbg(`cleanupThread: ${ptrToString(pthread_ptr)}`) | |||
| #endif | |||
| if (!PThread.pthreads[pthread_ptr]) return; | |||
There was a problem hiding this comment.
Why is this possible now? Maybe add a comment?
dschuff
reviewed
Aug 27, 2024
src/library.js
Outdated
| // When EXIT_RUNTIME is enabled the main thread will take care of shutting | ||
| // down the runtime, and killing all the workers/threads. | ||
| // However when EXIT_RUNTIME is no enabled we don't want the existance | ||
| // of this running thread to prevent node from exiting, do we use |
There was a problem hiding this comment.
Suggested change
| // of this running thread to prevent node from exiting, do we use | |
| // of this running thread to prevent node from exiting, so we use |
Prior to this change the thread calling `exit()` would itself keep the runtime alive. This change makes it easy to run arbitrary tests under `PROXY_TO_PTHREAD` without also needing to remember to add `EXIT_RUNTIME`
sbc100
force-pushed
the
pthread_exit_handling
branch
from
1507300
to
2415a09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the thread calling
exit()would itself keep the runtime alive.This change makes it easy to run arbitrary tests under
PROXY_TO_PTHREADwithout also needing to remember to addEXIT_RUNTIME