Append em-pthread id to the web worker name. #22644
Open
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently all web workers created for threads are called "em-pthread". So when using browser debug tools, you have to try out one web worker after another until you find the one you'd like to debug. |
kolAflash
force-pushed
the
main
branch
2 times, most recently
from
5ef6a5a
to
5748048
Compare
sbc100
reviewed
Sep 30, 2024
src/library_pthread.js
Outdated
| @@ -405,7 +405,7 @@ var LibraryPThread = { | |||
| #if ENVIRONMENT_MAY_BE_WEB || ENVIRONMENT_MAY_BE_WORKER | |||
| // This is the way that we signal to the Web Worker that it is hosting | |||
| // a pthread. | |||
| 'name': 'em-pthread', | |||
| 'name': 'em-pthread_' + PThread.nextWorkerID, | |||
There was a problem hiding this comment.
Can you use a hyphen here?
Simplifies picking a web worker when using browser debug tools.
sbc100
approved these changes
Sep 30, 2024
|
It looks like closure does't like this: |
|
Ah yes, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies picking a web worker when using browser debug tools.