tttool play: improve handling of the J command (#231) #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a bit more files for the test suite
Most or all Ravensburger GMEs have a duplicated Audio table. Most of them have an identical copy, but it seems not all. For those where the table is 80% equal, treat it like a copy (and throw away the extra information for now). It remains future work to make sense of this extra table.
The J() command is executed after all other commands in the line have executed. The 2s pause if no P() follows J() (as documented in entropia#179 (comment)) is not implemented yet.
|
If that is really the semantics on all pens, then what we should do is
|
tbleher
pushed a commit
to tbleher/tip-toi-reveng
that referenced
this pull request
Dec 5, 2020
As discussed in entropia#231 and entropia#238, TipToi pens handle a jump after all other actions (even if they are earlier in the list). If there are multiple jumps, only the last has an effect. This lint check verifies that a GME only contains one jump, and that the jump is the last action. This check is true for all GMEs published by Ravensburger.
Open
tbleher
pushed a commit
to tbleher/tip-toi-reveng
that referenced
this pull request
Dec 5, 2020
As discussed in entropia#231 and entropia#238, TipToi pens handle a jump after all other actions (even if they are earlier in the list). If there are multiple jumps, only the last has an effect. This lint check verifies that a GME only contains one jump, and that the jump is the last action. This check is true for all GMEs published by Ravensburger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ich bin vor kurzem darüber gestolpert, dass tttool play das J()-Kommando nicht richtig implementiert. Dieser Commit verbessert das Verhalten, auch wenn es noch nicht perfekt ist.
Ich vermute, dass man das wieder kürzer schreiben könnte, als ich das mit pattern matching geschrieben habe. Bin wie immer an Verbesserungsvorschlägen interessiert, um mein Haskell zu verbessern :)