Cherry-picking "Configurable heap memory release rate - #32589" #36363
Conversation
Expose config option for tcmalloc [memory background release rate](https://github.com/google/tcmalloc/blob/bf4db7e4c85b142ecdd37f8bf388075131c387e9/tcmalloc/malloc_extension.h#L637C15-L637C39, that eases tuning of tcmalloc in Envoy. Gperf tcmalloc is not yet supported in this change, as gperf tcmalloc memory release does not function the same way as tcmalloc does and introduced test flakiness. Commit Message: Additional Description: Risk Level: Testing: Unit tests Docs Changes: API docs Release Notes: Platform Specific Features: Signed-off-by: Kateryna Nezdolii <[email protected]> Signed-off-by: Kateryna Nezdolii <[email protected]> Co-authored-by: Matt Klein <[email protected]>
|
Hi @sakatkoori, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
|
@briansonnenberg @nezdolik We are working on a mesh solution, and we see the issue that memory is not released even after the existing connections gets closed when Overload manager configured and hit the threshold. Heap size is never coming down after the threshold hits, so, wanted to utilize this heap memory release along with the Overload manager. And this we need on v1.29, so could you please help review this. |
|
Don't think we backport features, is it possible to upgrade to Envoy version that contains the feature? |
|
branches are currently not working - trying to resolve that now - should be back up and running by early next week |
@nezdolik, Thanks for your note !!, and no, it is not possible, that is the reason trying for backport. |
|
@sakatkoori we don't backport features, only bug/security fixes. Best course of action for you would be either to upgrade or to maintain a private build for v1.29+memory release feature. |
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]