Error message to mention UpstreamCodec filter #36367
Open
+64
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raven Black <[email protected]>
|
/retest |
kyessenov
approved these changes
Sep 30, 2024
|
/assign-from @envoyproxy/senior-maintainers |
|
@envoyproxy/senior-maintainers assignee is @RyanTheOptimist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Error message to mention UpstreamCodec filter
Additional Description: The requirement described in #26138 doesn't seem to be mentioned in documentation, and even if it was I most likely wouldn't have seen it and probably neither would the person who filed the issue, so documenting the requirement in the failed validation error message seems a more practical solution.
I also moved the function implementation out of the header file, making for cleaner code but a more unpleasant review, sorry.
Risk Level: Only changes an error message, so ~none.
Testing: Added unit test coverage (previously coverage was partial and from integration tests).
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a