-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bp/1.30] CI migration stack #36393
Open
asedeno
wants to merge
9
commits into
envoyproxy:release/v1.30
Choose a base branch
from
asedeno:bp-1.30-ci-migration
base: release/v1.30
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[bp/1.30] CI migration stack #36393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
our existing RBE uses the GCR image rather than the dockerhub one this may/not be related to dockerhub rate limiting that seems to have started recently Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
…envoyproxy#36298) Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]> Signed-off-by: phlax <[email protected]>
Commit Message: use bash source rather than dirname $0 Additional Description: Risk Level: low. Testing: n/a. Docs Changes: n/a. Release Notes: n/a. Platform Specific Features: n/a. --------- Signed-off-by: wangbaiping <[email protected]> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
this test was never really run as `CI_BRANCH` is not automatically set in azp now the thing its testing has moved to bazel so the test is not really correct also im in the process of moving the thing being tested to toolshed (where it will be testsed more comprehensively) Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
asedeno
requested review from
wbpcode,
soulxu,
mattklein123,
alyssawilk,
ravenblackx,
phlax,
RyanTheOptimist,
abeyad,
fredyw,
kyessenov,
tyxia,
nezdolik,
yanavlasov,
ggreenway,
zuercher,
KBaichoo,
adisuissa and
jmarantz
as code owners
October 1, 2024 00:20
@phlax, we might have an easier time with DCO if you recreate this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.