Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2162 - Add support for rendering embedded SVGs while exporting to PNG #2299

Merged
merged 17 commits into from
Sep 9, 2024
Merged

#2162 - Add support for rendering embedded SVGs while exporting to PNG #2299

merged 17 commits into from
Sep 9, 2024

Conversation

nupagadi
Copy link
Collaborator

@nupagadi nupagadi commented Sep 4, 2024 •
edited
Loading

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

@nupagadi nupagadi changed the title 2162 svg to png 2162 - Add support for rendering embedded SVGs while exporting to PNG Sep 9, 2024
@nupagadi nupagadi linked an issue Sep 9, 2024 that may be closed by this pull request
Add support for rendering embedded SVGs while exporting to PNG #2162
Closed
@nupagadi nupagadi changed the title 2162 - Add support for rendering embedded SVGs while exporting to PNG #2162 - Add support for rendering embedded SVGs while exporting to PNG Sep 9, 2024
@nupagadi nupagadi marked this pull request as ready for review September 9, 2024 13:53
even1024
even1024 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@even1024 even1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look ok

@nupagadi nupagadi merged commit abe5422 into master Sep 9, 2024
74 checks passed
@nupagadi nupagadi deleted the 2162-svg_to_png branch September 9, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSavelyev AlexanderSavelyev AlexanderSavelyev approved these changes

@even1024 even1024 even1024 approved these changes

@AliaksandrDziarkach AliaksandrDziarkach Awaiting requested review from AliaksandrDziarkach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for rendering embedded SVGs while exporting to PNG
3 participants
@nupagadi @AlexanderSavelyev @even1024