source-postgres-batch: Add very minimal documentation #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be improved soon, but since we auto-open the page in a sidebar in our dashboard there needs to be *something* there immediately, and this is the bare minimum IMO.
willdonnelly
force-pushed
the
wgd/postgres-batch-20230803
branch
from
2312aa0
to
8c3a074
Compare
oliviamiannone
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
From that "bare minimum" perspective, this looks good to me. The one thing I think should definitely be added sooner than later would be some version of prerequisites, which I imagine is the same as the CDC connector, less the CDC-specific items.
in the future it'd be great to flesh out the last few paragraphs with some examples etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This should be improved some time, but since we auto-open the page in a sidebar in our dashboard there needs to be something there immediately, and this is the bare minimum IMO.
This change is