trie: parallel commit (alternative version) #30545
Open
+202
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holiman
commented
Oct 3, 2024
trie/committer.go
Outdated
| @@ -133,21 +156,20 @@ func (c *committer) store(path []byte, n node) node { | |||
| // deleted only if the node was existent in database before. | |||
| _, ok := c.tracer.accessList[string(path)] | |||
| if ok { | |||
| c.nodes.AddNode(path, trienode.NewDeleted()) | |||
| c.nodes.AddNode(path, trienode.NewDeleted()) // TODO | |||
holiman
force-pushed
the
parallel_commit_alt
branch
from
d1664dc
to
b13ad11
Compare
trie: test which shows that the commit is erroneous trie: make parallel committer correct trie/trienode: better merge of set fix error in bench
holiman
force-pushed
the
parallel_commit_alt
branch
from
b13ad11
to
e6591dd
Compare
holiman
force-pushed
the
parallel_commit_alt
branch
from
e6591dd
to
5d09de1
Compare
|
Running this on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #30461
I've attempted to do it differently.
With this approach, I get
So the
9ms->10msfor single-thread, and4msfor multi-threaded approach. The mem usage is only marginally higher than currentmaster.