Skip to content

Commit

Permalink
(Again) disable use of libssh2 when building cURL
Browse files Browse the repository at this point in the history
Without this change, we run into the problem where our GHA builder has the
libssh2 library installed (and so the built cURL dynamically links to it) but
the average mac user does not, leading to the application immediately
crashing on start.

This was already fixed once before, but with the recent(ish) upgrade to a
newer version of cURL than what we'd been using in f1dd6fe, the option
CMAKE_USE_LIBSSH2 was renamed to CURL_USE_LIBSSH2, which silently made
our forcing of that setting to OFF no longer work.
  • Loading branch information
bluebandit21 authored and poco0317 committed Dec 31, 2022
1 parent 2dd10f4 commit 1292209
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion extern/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ set(BUILD_SHARED_LIBS OFF) # Tell CMake to prefer static libs

# External Libraries
## Curl Specific Options
set(CMAKE_USE_LIBSSH2 OFF CACHE BOOL "" FORCE) # Disable curl libssh2
set(CURL_USE_LIBSSH2 OFF CACHE BOOL "" FORCE) # Disable curl libssh2
set(BUILD_CURL_EXE OFF CACHE BOOL "" FORCE) # Tell curl not to build standalone binary
set(BUILD_TESTING OFF CACHE BOOL "" FORCE) # Disable curl testing
set(CURL_USE_OPENSSL ON CACHE BOOL "" FORCE) # Require OpenSSL
Expand Down

0 comments on commit 1292209

Please sign in to comment.