GLFW to replace LowLevelWindow #1073
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrong name was chosen during the original cmake upgrade
git-subtree-dir: extern/glfw git-subtree-split: d1fc694bb5d194013b9ea10c0753ef83b7ecfe58
ActionDelegate stores references to functions to call when the action in invoked.
No longer needed with GLFW
Taken from a path from the previous version of this PR.
- Remove OpenGL int based version checking (they're only checking for 1.0 features) - Remove all references related to Concurrent Rendering
The macOS window decoration should no longer be blurry. The info.plist is updated to state the app supports retina, and the RageDisplay_OGL was updated to use the frame-buffer size over window dimensions. A custom MacOSXBundleInfo file was added to CMake as cmake doesn't enable retina by default. CMake had a discussion on this at https://gitlab.kitware.com/cmake/cmake/-/merge_requests/1167
This is required for proper mouse input
It was previously included transitivity.
- Remove unused reference - Remove replaced window creation
Other changes include: - Updating CreateDisplay function - Update GetActualGraphicOptionsString function - Changing links to PREFSMAN - Replacing usages of `GetActualVideoModeParams`, and removing said function - Replace usages of `bAnisorophicFiltering`, `bSmoothLines` and `bTrilinearFiltering` with their PREFSMAN equivalent
…SetFullscreen Most of VideoMode was written on linux, with this last part being done on Windows to fix compilation
Possibly a regression from the rebase
This delays every attempt to build by 2-3 seconds, when after this code is built, it's least likely to change
The framebuffer resize does not have the desired effect. Window resize does.
jameskr97
force-pushed
the
feature/glfw/v2-2
branch
from
23bfc1e
to
977f17a
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLFW to replace LowLevelWindow
This was originally attempted in #1013 though, and due to insufficient testing on the input side, was deemed unable to be merged. This PR is similar to #1013, except without any input-related changes. This PR only includes elements necessary for a Windowing system replacement, with the organization to only
StepMania.{cpp,hpp}.Changes Include
StepMania.{cpp,h}glewreplaced withgladsrc/arch/LowLevelWindow