Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter preset functionality #1277

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Alkorith
Copy link

This is a feature patch to mostly resolve #1145. The UI/UX is beyond the scope of this PR.

Rebirth Screenshots

Player pressed "Save"

2023-09-11-19_28_21

Player pressed "Export"

2023-09-11-19_28_55
2023-09-11-19_29_26

Til Death Screenshots

Player pressed "Save"

2023-09-11-19_30_57

Player pressed "Export"

2023-09-11-19_31_05
2023-09-11-19_31_13

commit 3f6636a
Author: Alkorith <[email protected]>
Date:   Mon Sep 11 11:25:05 2023 -0500

    feat(filterpreset): Implement loading/saving filter presets

commit 9872554
Author: Alkorith <[email protected]>
Date:   Mon Sep 11 11:30:53 2023 -0500

    chore(filterpresets): Add lunajson dependency
@poco0317
Copy link
Member

poco0317 commented Mar 12, 2024

save and export in this are rather redundant and should probably both go in the same folder - so we would eliminate one of those buttons.
i am interested in merging this, but i would prefer to know at least what we want the ui to look like even if it isnt coded yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants