Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsuck unpitch rates #1316

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Conversation

graemephi
Copy link
Contributor

This turned out to be easier than I expected

The main thing is not letting the left and right channels get time stretched/squeezed independently, which you can do with this nonsense. Less obtusely you can think of it as doing the algorithm on the average of the left/right channels instead of each independently, and then applying the change it wanted to make to both channels. And actually you could do exactly that, but I don't, because it helps masks an annoying issue to do with the way uncorrelated audio mixes, which makes certain noisey songs sound fluttery

The algorithm this thing uses still has a more fundamental issue which is on uprates it will just straight up skip beats. There's really no good reason for this but I don't think it can be fixed without just rewriting it entirely

Also some TWEAKS to make it SOUND GOOD
@poco0317
Copy link
Member

poco0317 commented Aug 5, 2024

this certainly sounds different than before

@poco0317 poco0317 merged commit 9956bb2 into etternagame:develop Aug 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants