Add cppcheck to test-workflow #17
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokenRat
force-pushed
the
feature/gitlab_cppcheck
branch
from
838eb34
to
a1527c0
Compare
|
Since this is a draft right now: Do you want to delay the merge? Otherwise feel free to merge I'd say |
|
They changed the parameters in the latest version. My local has '--pattern', the new one (in the pipeline) has --src-filter. And they behave differently: Without filter, in the pipeline it includes .pio which also contains FastLED, which we do not want to check. Right now it breaks in the pipeline. And I do not wanted to waste time on debugging this. For the long run, I'd love to have a pipeline that does these kind of checks. But for now… we got more pressing things to do. :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.