Skip to content

Commit

Permalink
Fix multiple fake devices during QR exchange
Browse files Browse the repository at this point in the history
Summary:
Device UDID is not available during the exchange. As such, we do a best attempt to find devices by name. This is fine except we append "via QR exchange" to said name which then makes it impossible to match.

Displaying "via QR exchange" also exposes an implementation detail which does not have a direct relationship with the device. so removing this from the dropdown displayed title seems appropriate.

Reviewed By: antonk52

Differential Revision: D58415038

fbshipit-source-id: 1518627d58c0134b0ed2c5e981c85ca2a492b992
  • Loading branch information
lblasa authored and facebook-github-bot committed Jun 11, 2024
1 parent 6a610b9 commit 2c0b489
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ export class ServerController
new DummyDevice(
this.flipperServer,
deviceId,
`${clientQuery.device} via QR Exchange`,
clientQuery.device,
clientQuery.os,
),
);
Expand Down

0 comments on commit 2c0b489

Please sign in to comment.