Skip to content

Commit

Permalink
Drop SDK 19 tests (2)
Browse files Browse the repository at this point in the history
Summary:
The next Robolectric release drops support for SDK 19 (KitKat). Nearly all apps are min SDK 21+ anyway.

The strategy here:
- If a test was explicitly designed to test a pre-21 code path, just remove it
- If the test passes on the latest SDK, just remove the SDK-19 config
- else, pin the test on SDK 21, punting the issue.

Reviewed By: jiawei-lyu, xiphirx

Differential Revision: D59983594

fbshipit-source-id: e12b660b3f9af4fb62a29265e7e4b80d7eacdb5d
  • Loading branch information
Joshua Selbo authored and facebook-github-bot committed Jul 20, 2024
1 parent d140f59 commit 5ff667a
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@

@LooperMode(LEGACY)
@RunWith(RobolectricTestRunner.class)
@Config(sdk = 19)
@Config(sdk = 21)
public class InspectorFlipperPluginTest {

private MockApplicationDescriptor mApplicationDescriptor;
Expand Down Expand Up @@ -297,7 +297,7 @@ protected NodeDescriptor<Object> descriptorForObject(Object obj) {
.put("1", new FlipperObject.Builder()))))
.put(
"path",
new FlipperArray.Builder().put("com.facebook.flipper").put("test").put("1"))
new FlipperArray.Builder().put("com.facebook.flipper").put("test").put("3"))
.build()));
}

Expand Down

0 comments on commit 5ff667a

Please sign in to comment.