Skip to content

Commit

Permalink
do not log errors when dynamic plugins failed to load because of died…
Browse files Browse the repository at this point in the history
… websocket

Summary: This particular error creates unactionable tasks for the flipper team.

Reviewed By: mweststrate

Differential Revision: D62637937

fbshipit-source-id: ee9b2f53e507a5c948ad0749db2f9f5fc76c91f6
  • Loading branch information
antonk52 authored and facebook-github-bot committed Sep 13, 2024
1 parent f76d3d5 commit e3d7b23
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion desktop/flipper-ui/src/dispatcher/plugins.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,13 @@ export async function getDynamicPlugins(): Promise<InstalledPluginDetails[]> {
try {
return await getFlipperServer().exec('plugins-load-dynamic-plugins');
} catch (e) {
console.error('Failed to load dynamic plugins', e);
if (
e.toString().includes('Flipper Server disconnected. Reason: ws-close')
) {
console.warn('Failed to load dynamic plugins', e);
} else {
console.error('Failed to load dynamic plugins', e);
}
return [];
}
}
Expand Down

0 comments on commit e3d7b23

Please sign in to comment.