Use ${{ github.workspace }} variable in CI

[bdice]

This PR does some cleanup to replace hardcoded paths with ${{ github.workspace }}. This helps make CI more robust on forks.

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	33849fa
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/66a1d774c912d20008fa5d92

[bdice]

@assignUser Could you (or someone familiar with Velox CI) review this? Thanks!

[bdice]

I'm seeing this compiler error in CI. I see this on other PRs as well (like this one on PR 10556), so I don't think it is related to my changes.

FAILED: velox/buffer/CMakeFiles/velox.dir/__/functions/remote/if/GetSerde.cpp.o 
/usr/bin/ccache /opt/rh/gcc-toolset-12/root/bin/g++ -DAWS_SDK_VERSION_MAJOR=1 -DAWS_SDK_VERSION_MINOR=11 -DAWS_SDK_VERSION_PATCH=321 -DAWS_USE_EPOLL -DAZ_RTTI -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_DYN_LINK -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DCURL_STATICLIB -DFOLLY_HAVE_INT128_T=1 -DGFLAGS_IS_A_DLL=0 -DSIMDJSON_THREADS_ENABLED=1 -DUSE_OS_TZDB -DVELOX_ENABLE_ABFS -DVELOX_ENABLE_GCS -DVELOX_ENABLE_HDFS3 -DVELOX_ENABLE_PARQUET -DVELOX_ENABLE_S3 -I/usr/local/cuda-12.4/targets/x86_64-linux/include -I/__w/velox/velox/. -I/__w/velox/velox/velox/external/xxhash -I/__w/velox/velox/_build/release -I/__w/velox/velox/velox/tpch/gen/dbgen/include -I/__w/velox/velox/_build/release/_deps/xsimd-src/include -I/__w/velox/velox/_build/release/_deps/simdjson-src/include -I/__w/velox/velox/_build/release/_deps/curl-src/include -isystem /__w/velox/velox/_build/release/_deps/protobuf-src/src -isystem /__w/velox/velox/velox -isystem /__w/velox/velox/velox/external -isystem /__w/velox/velox/velox/external/date/velox/external -isystem /usr/include/libdwarf-0 -isystem /__w/velox/velox/_build/release/_deps/libstemmer/src/libstemmer/include -mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2 -D USE_VELOX_COMMON_BASE -D HAS_UNCAUGHT_EXCEPTIONS -Wall -Wextra -Wno-unused        -Wno-unused-parameter        -Wno-sign-compare        -Wno-ignored-qualifiers        -Wnon-virtual-dtor        -Wno-implicit-fallthrough          -Wno-class-memaccess          -Wno-comment          -Wno-int-in-bool-context          -Wno-redundant-move          -Wno-array-bounds          -Wno-maybe-uninitialized          -Wno-unused-result          -Wno-format-overflow          -Wno-strict-aliasing -Werror -O3 -DNDEBUG -std=gnu++17 -fPIC -fdiagnostics-color=always -fsized-deallocation -fPIC -MD -MT velox/buffer/CMakeFiles/velox.dir/__/functions/remote/if/GetSerde.cpp.o -MF velox/buffer/CMakeFiles/velox.dir/__/functions/remote/if/GetSerde.cpp.o.d -o velox/buffer/CMakeFiles/velox.dir/__/functions/remote/if/GetSerde.cpp.o -c /__w/velox/velox/velox/functions/remote/if/GetSerde.cpp
In file included from /__w/velox/velox/velox/functions/remote/if/GetSerde.cpp:17:
/__w/velox/velox/./velox/functions/remote/if/GetSerde.h:19:10: fatal error: velox/functions/remote/if/gen-cpp2/RemoteFunction_types.h: No such file or directory
   19 | #include "velox/functions/remote/if/gen-cpp2/RemoteFunction_types.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

#10557 will probably fix this.

[assignUser]

#10557 will probably fix this.

Yes you can rebase now.

[bdice]

Thanks @assignUser. I rebased this. Typically I would merge in the upstream. For future reference, does Velox prefer rebases?

[assignUser]

Thanks. Either way is fine as in the end it will be squashed for the merge :)

[bdice]

@assignUser I am seeing some fuzz test failures. I'm not sure if those are required or not to merge, but it doesn't seem related to my PR. Could you review and merge this when you are able?

[kgpai]

@bdice Fuzzer failures are unrelated to your change.

[facebook-github-bot]

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[bdice]

Thank you all! 😊

[facebook-github-bot]

@Yuhta merged this pull request in b9d0091.