Support custom comparison in RowContainer #11024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D62905323 |
pansatadru
approved these changes
Sep 20, 2024
|
This pull request was exported from Phabricator. Differential Revision: D62905323 |
kevinwilfong
pushed a commit
to kevinwilfong/velox
that referenced
this pull request
Sep 24, 2024
Summary: Pull Request resolved: facebookincubator#11024 Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in RowContainer. Again, compare was already handled by updating SimpleVector, so this just updates the hash function and adds tests. Reviewed By: pansatadru Differential Revision: D62905323
kevinwilfong
force-pushed
the
export-D62905323
branch
from
78953cc
to
ab4df31
Compare
Summary: Pull Request resolved: facebookincubator#11024 Building on facebookincubator#11021 this adds support for custom comparison functions provided by custom types in RowContainer. Again, compare was already handled by updating SimpleVector, so this just updates the hash function and adds tests. Reviewed By: pansatadru Differential Revision: D62905323
|
This pull request was exported from Phabricator. Differential Revision: D62905323 |
kevinwilfong
force-pushed
the
export-D62905323
branch
from
ab4df31
to
80a57be
Compare
|
This pull request has been merged in 367faf8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Building on #11021 this adds support for custom
comparison functions provided by custom types in RowContainer.
Again, compare was already handled by updating SimpleVector, so this just updates the hash
function and adds tests.
Differential Revision: D62905323