Fix GCS credential config and rename to hive.gcs.json-key-file-path #11086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@tigrux do you have any feedback on this? |
|
Thanks for taking care of this. |
majetideepak
changed the title
czentgr
approved these changes
Sep 27, 2024
majetideepak
added
the
ready-to-merge
|
Hi @majetideepak, there seems to be a build error from GCSFileSystemTest.cpp in the failed CI job (https://github.com/facebookincubator/velox/actions/runs/11033835431/job/30645931332?pr=11086). Could you take a look? |
majetideepak
force-pushed
the
fix-velox-gcs
branch
from
fc99669
to
5193871
Compare
|
@kagamiori GCSFileSystemTest on CI is now passing. Thanks! |
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in fcc1b1c. |
|
Conbench analyzed the 1 benchmark run on commit There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
hive.gcs.credentialsexpects a JSON string with the GCS service account configuration.However, this JSON string is expected to be unescaped by the google C++ SDK. It is not possible to pass an unescaped JSON string via a config file.
The norm seems to specify a file path with the service account configuration.
Presto uses
hive.gcs.json-key-file-path. Velox will use the same.https://github.com/prestodb/presto/blob/62ca0801fba8448b162fe89f8dab10e0c14158e1/presto-docs/src/main/sphinx/release/release-0.225.rst#hive-changes