Add Spark CAST(integral as timestamp) #11089
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
Hey @rui-mo, could you please help review this? |
rui-mo
reviewed
Sep 27, 2024
| } else if (seconds < -maxSeconds) { | ||
| return Timestamp::fromMicros(std::numeric_limits<int64_t>::min()); | ||
| } | ||
| return Timestamp::fromMillis(seconds * kMillisInSecond); |
There was a problem hiding this comment.
Can we create Timestamp with the constructor Timestamp(int64_t seconds, uint64_t nanos)?
There was a problem hiding this comment.
sure, let me fix it
| makeNullableFlatVector<Timestamp>( | ||
| {Timestamp(0, 0), | ||
| Timestamp(1, 0), | ||
| Timestamp::fromMillis( |
| // Ensure that other integral types cast to int64 work as well. | ||
| testIntegralToTimestampCast<int8_t>(); | ||
| testIntegralToTimestampCast<int16_t>(); | ||
| testIntegralToTimestampCast<int32_t>(); |
There was a problem hiding this comment.
I wonder why we adopt different test methods for int64_t and the others. Is there any special consideration?
There was a problem hiding this comment.
since other integral types can't test large timestamp values, and since we only need to ensure cast smaller integral to int64_t works well, so here I adopt different test methods
rui-mo
changed the title
boneanxs
force-pushed
the
support_number_to_timestamp
branch
from
ff47627
to
c09a126
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Spark
cast(integral to timestamp)