Clean up overuse of auto in MapConcat.cpp #11152
Closed
+28
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D63723010 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D63723010 |
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Oct 2, 2024
Summary: Pull Request resolved: facebookincubator#11152 Wherever the type of any variable is not clear due to the use of auto, it was excpliticly declared instead. Differential Revision: D63723010
DanielHunte
force-pushed
the
export-D63723010
branch
from
5aa29a7
to
bcc537c
Compare
DanielHunte
pushed a commit
to DanielHunte/velox
that referenced
this pull request
Oct 2, 2024
Summary: Wherever the type of any variable is not clear due to the use of auto, it was excpliticly declared instead. Differential Revision: D63723010
DanielHunte
force-pushed
the
export-D63723010
branch
from
bcc537c
to
eb4d2d5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63723010 |
Summary: Wherever the type of any variable is not clear due to the use of auto, it was excpliticly declared instead. Differential Revision: D63723010
DanielHunte
force-pushed
the
export-D63723010
branch
from
eb4d2d5
to
92a4e9d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D63723010 |
|
This pull request has been merged in b543230. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Wherever the type of any variable is not clear due to the use of auto, it was excpliticly declared instead.
Differential Revision: D63723010