Add support for custom comparison in Presto's arrays intersect/except/overlap UDFs #11164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 3, 2024 11:53
…kincubator#11141) Summary: With facebookincubator#11136 array_min and array_max just work with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Differential Revision: D63708110
…r#11142) Summary: With facebookincubator#11136 array_sort just works with TimestampWithTimezone. Adding unit tests to verify this and ensure it doesn't break in the future. Reviewed By: bikramSingh91 Differential Revision: D63711984
…kincubator#11143) Summary: Update Presto's array_distinct UDF to work with types that provide custom comparison. We can reuse the implementation of ValueSet for complex types, since that just uses the compare and hash functions provided by the Vector. With facebookincubator#11022 these just invoke the Type's custom implementations of these functions. Reviewed By: xiaoxmeng Differential Revision: D63719542
…/overlap UDFs Summary: Update Presto's array_intersect, array_except, and array_overalp UDFs to work with types that provide custom comparison. We can reuse the implementation of ValueSet for complex types, since that just uses the compare and hash functions provided by the Vector. With facebookincubator#11022 these just invoke the Type's custom implementations of these functions. Differential Revision: D63851047
|
This pull request was exported from Phabricator. Differential Revision: D63851047 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Update Presto's array_intersect, array_except, and array_overalp UDFs to work with
types that provide custom comparison. We can reuse the implementation of ValueSet
for complex types, since that just uses the compare and hash functions provided by
the Vector. With #11022 these just
invoke the Type's custom implementations of these functions.
Differential Revision: D63851047