Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapping up the prototype for the new GR4 graph #25

Merged
merged 4 commits into from
Feb 1, 2023
Merged

Wrapping up the prototype for the new GR4 graph #25

merged 4 commits into from
Feb 1, 2023

Conversation

ivan-cukic
Copy link
Contributor

No description provided.

@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 09:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 09:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 09:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 09:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 09:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 12:03 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 12:03 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 12:03 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 12:03 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 12:03 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 12:03 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 13:12 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 13:12 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 13:12 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 13:12 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 13:12 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 1, 2023 13:12 — with GitHub Actions Inactive
RalphSteinhagen
RalphSteinhagen approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the refactoring changes. I like the new safe_min, tuple_for_each, and tuple_transform functions! These make the existing work(..) more readable. LGTM & well done!
👍

@ivan-cukic ivan-cukic linked an issue Feb 1, 2023 that may be closed by this pull request
[0pt,6pt] Clean up the prototype code for presenting to wider GR audience fair-acc/opendigitizer#45
Closed
8 tasks
@RalphSteinhagen RalphSteinhagen merged commit 4201658 into main Feb 1, 2023
@RalphSteinhagen RalphSteinhagen deleted the ivan/wrapping-up-the-prototype branch February 1, 2023 13:24
@RalphSteinhagen RalphSteinhagen mentioned this pull request Feb 2, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0pt,6pt] Clean up the prototype code for presenting to wider GR audience
2 participants
@ivan-cukic @RalphSteinhagen