Allow ports to be defined as class member variables #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
force-pushed
the
ivan/repl-cpp-and-ports-as-members
branch
4 times, most recently
from
bd6a276
to
ec06c96
Compare
ivan-cukic
force-pushed
the
ivan/repl-cpp-and-ports-as-members
branch
from
ec06c96
to
d5227fd
Compare
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
ivan-cukic
temporarily deployed
to
configure coverage
GitHub Actions
Inactive
RalphSteinhagen
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Thanks a lot @ivan-cukic ! LGTM. 👍
N.B. Most of the changes/iterations were done iteratively via discussing this in jitsi!
Closed
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.