Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SIMD support to the work function #36

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Added SIMD support to the work function #36

merged 2 commits into from
Feb 9, 2023

Conversation

ivan-cukic
Copy link
Contributor

No description provided.

@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 8, 2023 20:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 8, 2023 20:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 8, 2023 20:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 8, 2023 20:28 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 09:48 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 09:48 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 09:48 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 09:48 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 09:48 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 09:48 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 10:09 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 10:09 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 10:09 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 10:09 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 10:09 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 10:09 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:14 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:14 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:14 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:14 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:14 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:14 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:36 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:36 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:36 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:36 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:36 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:36 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:39 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:39 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:39 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:39 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:39 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 11:39 — with GitHub Actions Inactive
RalphSteinhagen
RalphSteinhagen approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ivan-cukic for putting all the work in this clean-up iteration. Looks good!

As discussed the mixing of SIMD-operation with different scalar types and SIMD-widths would need to be discussed and re-evaluated with @mattkretz, but I think for now the present state is sufficient.

@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 12:31 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 12:31 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 12:31 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 12:31 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 12:31 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 9, 2023 12:31 — with GitHub Actions Inactive
@RalphSteinhagen RalphSteinhagen merged commit 695aa5f into main Feb 9, 2023
@RalphSteinhagen RalphSteinhagen deleted the ivan/simd-for-node branch February 9, 2023 12:34
@RalphSteinhagen RalphSteinhagen linked an issue Feb 14, 2023 that may be closed by this pull request
[0pt,6pt] Clean up the prototype code for presenting to wider GR audience fair-acc/opendigitizer#45
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[0pt,6pt] Clean up the prototype code for presenting to wider GR audience
2 participants
@ivan-cukic @RalphSteinhagen