Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pointer that denotes node's owning graph #37

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

ivan-cukic
Copy link
Contributor

No description provided.

@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 11, 2023 11:00 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 11, 2023 11:00 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 11, 2023 11:00 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 11, 2023 11:00 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 11, 2023 11:00 — with GitHub Actions Inactive
@ivan-cukic ivan-cukic temporarily deployed to configure coverage February 11, 2023 11:00 — with GitHub Actions Inactive
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sorry for having to iterate on this... mea culpa....
But I think this is a better maintainable and compositable design.

@ivan-cukic thanks a lot for the changes!

@RalphSteinhagen RalphSteinhagen merged commit b082cf8 into main Feb 11, 2023
@RalphSteinhagen RalphSteinhagen deleted the ivan/remove-graph-ptr branch February 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0pt,6pt] Clean up the prototype code for presenting to wider GR audience
2 participants