-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(falco): add base_syscalls.all option to replace -A #3352
base: master
Are you sure you want to change the base?
new(falco): add base_syscalls.all option to replace -A #3352
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I like the idea; let's deprecated yet another CLI option! |
2abd2db
to
e4e41f8
Compare
need to fix formatting / tests |
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
e4e41f8
to
f71fc81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; same comment as #3362 (comment) applies here too; wdyt?
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This adds
base_syscalls.all
replacing-A
.This PR has not yet been linted. If the lint PR is merged I will update.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: