Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(config/clusters/ecr.tf): autobump ecr force delete. #1133

Conversation

cappellinsamuele
Copy link
Contributor

This PR forces delete autobump ecr resource.

@maxgio92
Copy link
Member

Are we sure we want to prune the repository @cappellinsamuele?

@cappellinsamuele
Copy link
Contributor Author

Are we sure we want to prune the repository @cappellinsamuele?

Maybe it is better to wait until we are sure everything is ok

@maxgio92
Copy link
Member

Let's put this on hold :)

/hold

@maxgio92
Copy link
Member

maxgio92 commented May 16, 2023

Let's wait for #1132.
Closes #856.

@cappellinsamuele cappellinsamuele force-pushed the cleanup/force_delete_autobump_ecr branch from 5042d4e to f1e3c3e Compare July 5, 2023 14:37
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

LGTM label has been added.

Git tree hash: 36b80190b13b9397bead41d794429c2a17d525e0

@poiana poiana added the approved label Jul 5, 2023
@cappellinsamuele cappellinsamuele force-pushed the cleanup/force_delete_autobump_ecr branch from f1e3c3e to f00b1da Compare July 5, 2023 15:16
@poiana poiana removed the lgtm label Jul 5, 2023
@poiana poiana requested a review from FedeDP July 5, 2023 15:16
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Jul 5, 2023
@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

LGTM label has been added.

Git tree hash: 47b62fc8c4ad3b3e37452c4c94decc5f4f298575

@FedeDP
Copy link
Contributor

FedeDP commented Jul 5, 2023

/unhold

@FedeDP
Copy link
Contributor

FedeDP commented Jul 5, 2023

#1132 was merged!

@poiana poiana merged commit bf88bb9 into falcosecurity:master Jul 5, 2023
1 check passed
@poiana
Copy link
Contributor

poiana commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cappellinsamuele, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants