added support for launch images for android #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-m-sharpe
force-pushed
the
launch_images_improvements
branch
3 times, most recently
from
4e77b48
to
0ceb6fe
Compare
josh-m-sharpe
force-pushed
the
launch_images_improvements
branch
from
0ceb6fe
to
4be7141
Compare
joshdholtz
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase/refactor of #53 which addresses the concerns I had in the comments there. /cc
@RishabhTayal
Supports:
-- Adds them to both "drawable-" and "drawable-port-" directories
This PR also takes the approach of resizing the image and then cropping it to size which retains the aspect ratio of the original image.