Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bundle #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

NikolaMandic
Copy link

To support latest bundle requirement for google play store here is extra option added

@jappe999
Copy link

Is it possible to merge this pull request? App bundles will be mandatory for new apps starting from the second half of this year.

@adamsteen
Copy link

This would be a great option!

@joshdholtz joshdholtz self-assigned this Mar 17, 2021
@joshdholtz
Copy link
Member

On it!

@andrey3diq
Copy link

This PR is adding the --bundle parameter for build. Are you sure it's working as expected?
Running the command ionic cordova build android --bundle still builds the apk file.
Instead, the ionic cordova build android -- -- --packageType=bundle command should be used.

@NikolaMandic
Copy link
Author

yes either as @andrey3diq said or go into platforms folder and do gradle buildRelease it has to be changed

@joshdholtz
Copy link
Member

Is there any documentation for ionic cordova build android --bundle? I can’t see this anywhere. I’m only seeing ionic cordova build android -- -- --packageType=bundle in any searches I do 🤷‍♂️

@kevinboosten
Copy link

Hi @joshdholtz --bundle is no valid argument as @andrey3diq mentioned. So the command you are using is the right one.

Here you see the Ionic v3 docs regarding Cordova builds:
https://ionicframework.com/docs/v3/cli/cordova/build/

And here the cordova docs:

@srtomus
Copy link

srtomus commented Sep 20, 2021

Any solutions to this?

@jappe999
Copy link

In my current solution I make use of a build config file that specifies the packageType option:

{
  "android": {
    "release": {
      "packageType": "bundle"
    }
  }
}

This config file can be referenced using the cordova_build_config_file option, like so:

ionic(
  platform: 'android',
  prod: true,
  cordova_build_config_file: 'build_config.json',
)

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants