fix: Removed usage of pull_request_target as much as possible to prevent security concerns #6436
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: pr-local-integration-tests | |
# This runs local tests with containerized stubs of online stores. This is the main dev workflow | |
on: | |
pull_request: | |
types: | |
- opened | |
- synchronize | |
- labeled | |
jobs: | |
integration-test-python-local: | |
# when using pull_request_target, all jobs MUST have this if check for 'ok-to-test' or 'approved' for security purposes. | |
#TODO not sure this check is needed anymore, changed to on pull_request | |
if: | |
((github.event.action == 'labeled' && (github.event.label.name == 'approved' || github.event.label.name == 'lgtm' || github.event.label.name == 'ok-to-test')) || | |
(github.event.action != 'labeled' && (contains(github.event.pull_request.labels.*.name, 'ok-to-test') || contains(github.event.pull_request.labels.*.name, 'approved') || contains(github.event.pull_request.labels.*.name, 'lgtm')))) && | |
github.event.pull_request.base.repo.full_name == 'feast-dev/feast' | |
runs-on: ${{ matrix.os }} | |
strategy: | |
fail-fast: false | |
matrix: | |
python-version: [ "3.11" ] | |
os: [ ubuntu-latest ] | |
env: | |
OS: ${{ matrix.os }} | |
PYTHON: ${{ matrix.python-version }} | |
steps: | |
- uses: actions/checkout@v4 | |
with: | |
repository: ${{ github.event.repository.full_name }} # Uses the full repository name | |
ref: ${{ github.ref }} # Uses the ref from the event | |
token: ${{ secrets.GITHUB_TOKEN }} # Automatically provided token | |
submodules: recursive | |
- name: Setup Python | |
uses: actions/setup-python@v5 | |
id: setup-python | |
with: | |
python-version: ${{ matrix.python-version }} | |
architecture: x64 | |
- name: Install uv | |
run: curl -LsSf https://astral.sh/uv/install.sh | sh | |
- name: Get uv cache dir | |
id: uv-cache | |
run: | | |
echo "::set-output name=dir::$(uv cache dir)" | |
- name: uv cache | |
uses: actions/cache@v4 | |
with: | |
path: ${{ steps.uv-cache.outputs.dir }} | |
key: ${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-uv-${{ hashFiles(format('**/py{0}-ci-requirements.txt', env.PYTHON)) }} | |
- name: Install dependencies | |
run: make install-python-ci-dependencies-uv | |
- name: Test local integration tests | |
if: ${{ always() }} # this will guarantee that step won't be canceled and resources won't leak | |
run: make test-python-integration-local |