Skip to content

Commit

Permalink
updated tests
Browse files Browse the repository at this point in the history
Signed-off-by: Francisco Javier Arceo <[email protected]>
  • Loading branch information
franciscojavierarceo committed Sep 30, 2024
1 parent 3662102 commit 74e7ede
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions sdk/python/tests/unit/online_store/test_online_writes.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ def setUp(self):
)
# Before apply() join_keys is empty
assert driver_stats_fv.join_keys == []
assert driver_stats_fv.entity_columns == []

@on_demand_feature_view(
sources=[driver_stats_fv[["conv_rate", "acc_rate"]]],
Expand Down Expand Up @@ -104,6 +105,8 @@ def test_view(inputs: dict[str, Any]) -> dict[str, Any]:
)
# after apply() join_keys is [driver]
assert driver_stats_fv.join_keys == [driver.join_key]
assert driver_stats_fv.entity_columns[0].name == driver.join_key

self.store.write_to_online_store(
feature_view_name="driver_hourly_stats", df=driver_df
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -615,7 +615,7 @@ def python_stored_writes_feature_view(

# Note here that after apply() is called, the entity_columns are populated with the join_key
# assert fv_applied.entity_columns[0].name == driver.join_key
assert fv_applied.entity_columns == []
assert fv_applied.entity_columns[0].name == driver.join_key
assert odfv_applied.entity_columns[0].name == driver.join_key

assert len(self.store.list_all_feature_views()) == 2
Expand Down

0 comments on commit 74e7ede

Please sign in to comment.