Update Spin dependencies #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rylev I can look at validating it |
|
@rylev can you update the build action to Rust 1.79 to get the tests working? spin-trigger-sqs/.github/workflows/build.yml Lines 36 to 37 in 48ef478 |
|
@rylev local test worked 🎉 |
Signed-off-by: Ryan Levick <[email protected]>
kate-goldenring
approved these changes
Sep 16, 2024
|
Should we update the MSRV in Cargo.toml? That remains at 1.76. Or is it only the tests that need 1.79? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't get a chance to test this against an actual SQS service so I cannot verify with 100% certainty that it works. If it's easy for someone to test these changes against an SQS instance that would be great otherwise, I will dust off my ol' AWS account.