Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebase Data Connect quickstart #1671

Open
wants to merge 50 commits into
base: master
Choose a base branch
from
Open

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Sep 25, 2024

TODO before merging this PR:

  • Add Search feature
  • Let users update and delete reviews
  • Make sure all the errors are correctly shown in the UI
  • Make sure all the tiles are clickable (movies, actors, reviews)
  • Remove all TODO comments
  • Update README.md to remove steps that were only meant for private preview
  • Migrate from alpha to beta
  • Use the latest schema from the Web quickstart (https://github.com/firebase/quickstart-js/tree/master/dataconnect)

Our GitHub Actions CI will fail at the moment because we're not doing the FDC SDK generation. I will fix that in a follow-up PR - tracking in #1672.

dataconnect/README.md Outdated Show resolved Hide resolved
dataconnect/README.md Outdated Show resolved Hide resolved
dataconnect/README.md Outdated Show resolved Hide resolved
dataconnect/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@marinacoelho marinacoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking very good! Just added some suggestions and some questions/points for us to discuss before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants