Skip to content

Commit

Permalink
Fix infrared keys list padding (#862)
Browse files Browse the repository at this point in the history
**Background**

On infrared screen, when enabled android buttons gesture navigation, the
last button located beyound bottom navigation

**Changes**

- Add element into list with bottom nav panel padding. The padding not
added to column itself to save transparent display of navigation panel.

**Test plan**
- Enabled buttons panel navigation in device settings
- Open infrared editor with more keys than screen height
- Scroll down
- See the last element now not located beyound bottom navigation
  • Loading branch information
makeevrserg authored May 23, 2024
1 parent 61e925e commit c089430
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
- [FIX] Text overflow on apps card
- [FIX] SD Card error on installed screen
- [FIX] Scrolling of zoomed screenshots in app image preview
- [FIX] Infrared editor screen bottom navigation padding
- [FIX] Display MfKey32 loading progress when no keys available
- [FIX] Return baseline profiles
- [Feature] Add not connected, empty and syncing states to emulation button on key screen
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package com.flipperdevices.infrared.editor.compose.screen

import androidx.compose.foundation.background
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Box
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.navigationBarsPadding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.itemsIndexed
import androidx.compose.runtime.Composable
Expand Down Expand Up @@ -89,6 +91,7 @@ internal fun ComposableInfraredEditorScreenReady(
)
}
}
item { Box(modifier = Modifier.navigationBarsPadding()) }
}
}
}

0 comments on commit c089430

Please sign in to comment.