Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: Check for todos #3011

Merged
merged 15 commits into from
Aug 25, 2023
Merged

github: Check for todos #3011

merged 15 commits into from
Aug 25, 2023

Conversation

hedger
Copy link
Member

@hedger hedger commented Aug 25, 2023 •
edited by skotopes
Loading

What's new

  • Commits with HACK, TODO, FIXME and XXX in changes without attached [FL-xxxxx] ticket will fail checks
  • Can be suppressed with -nofl in same line

Verification

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

Compiled firmware for commit 0a53c8ce:

@hedger hedger changed the title github: initial check for todos github: Check for todos Aug 25, 2023
@hedger hedger marked this pull request as ready for review August 25, 2023 12:09
@skotopes skotopes merged commit c3aa151 into dev Aug 25, 2023
8 checks passed
@skotopes skotopes deleted the hedger/ghtodos branch August 25, 2023 14:38
@hedger hedger added Build System & Scripts fbt, scripts and toolchain-related New Feature Contains an IMPLEMENTATION of a new feature labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skotopes skotopes skotopes approved these changes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya drunkbatya is a code owner

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related New Feature Contains an IMPLEMENTATION of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @skotopes