目覚め時計 #3906
Draft
目覚め時計 #3906
+851
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skotopes
requested review from
DrZlo13,
hedger,
gsurkov and
nminaylov
as code owners
|
Compiled f7 firmware for commit |
| memset(datetime, 0, sizeof(DateTime)); | ||
|
|
||
| datetime->hour = __LL_RTC_CONVERT_BCD2BIN(LL_RTC_ALMA_GetHour(RTC)); | ||
| datetime->minute = __LL_RTC_CONVERT_BCD2BIN(LL_RTC_ALMA_GetMinute(RTC)); |
There was a problem hiding this comment.
Seconds are set in the setter, but they are not read here.
There was a problem hiding this comment.
The basic alarm function works well, incl. waking up the Flipper when it was shut down.
A few notes/ideas, knowing full well that this PR is WIP so I'm aware that some of those may already be planned:
- A "bell" icon, like the Bluetooth/SD card icons are placed currently
- Perhaps allow applications to use ALMB while ALMA is "reserved" for the inbuilt Clock app. Make it possible for the app to choose if it wants to get the default "wake up!" screen and wake the Flipper up, or if it wants to control that by itself
- Allow applications to subscribe to the alarm ISR at least for ALMB, right now it seems to be dominated by the Clock app
- If ALMA and ALMB get exposed to apps, reset them when resetting Flipper settings, and maybe also offer a "Reset alarms" option in the Clock app, if some app leaves alarms configured in a weird state
- One shot timers? Both in furi rtc, and in the Clock app
Co-authored-by: Silent <[email protected]>
Co-authored-by: Silent <[email protected]>
Co-authored-by: Silent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)