Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Upgrade coreos/go-oidc to v3 to pickup claims parsing fixes #618

Closed
wants to merge 1 commit into from

Conversation

EngHabu
Copy link
Contributor

@EngHabu EngHabu commented Sep 26, 2023

TL;DR

Reference conversation

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (af81751) 59.03% compared to head (d338e01) 60.54%.

❗ Current head d338e01 differs from pull request most recent head 77be145. Consider uploading reports for the commit 77be145 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   59.03%   60.54%   +1.51%     
==========================================
  Files         171      171              
  Lines       16481    13454    -3027     
==========================================
- Hits         9729     8146    -1583     
+ Misses       5901     4457    -1444     
  Partials      851      851              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
auth/auth_context.go 0.00% <ø> (ø)
auth/authzserver/resource_server.go 49.23% <ø> (+3.34%) ⬆️
auth/token.go 0.00% <ø> (ø)

... and 155 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor

Hi, we are moving all Flyte development to a monorepo. In order to help the transition period, we're moving open PRs to monorepo automatically and your PR was moved to flyteorg/flyte#4139. Notice that if there are any conflicts in the resulting PR they most likely happen due to the change in the import path of the flyte components.

@eapolinario eapolinario closed this Oct 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants