Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snackbar): fixed the removal of snackbar #155

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

Shruti3004
Copy link
Collaborator

@Shruti3004 Shruti3004 commented Aug 16, 2021

Description

Closes #154

Changes

Added setTimeout of 2 seconds for all the alerts.

How to test

Visit all the routes.

Screencast from 16-08-21 12_59_53 PM IST
Screencast from 16-08-21 12_59_34 PM IST

@sjha2048
Copy link
Collaborator

Snackbar component needs some refactoring (need to convert it to a hook)
We should keep this PR on hold till then.

@GMishx
Copy link
Member

GMishx commented Aug 18, 2021

Isn't 2 second a very small interval for someone not expecting to see a snackbar? What about increasing it to 8 or 10 seconds as user can manually close it anyways?

Base automatically changed from development to main August 18, 2021 05:49
@GMishx GMishx changed the base branch from main to development August 18, 2021 05:50
@Shruti3004
Copy link
Collaborator Author

Isn't 2 second a very small interval for someone not expecting to see a snackbar? What about increasing it to 8 or 10 seconds as user can manually close it anyways?

Yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Need code review needs test Needs testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants