Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added GET endpoints #9

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

k-avy
Copy link
Collaborator

@k-avy k-avy commented Jun 14, 2023

fixes the first two tasks of issue 1

This consists of two end points:

  • Get all licenses
    • to get all the details of the licenses present in the database.
    • gets the data of all the data components present in the database.
  • Get licenses by shortname:
    • to get the data of the license with the shortname passed as a parameter.
    • error when no such license found.

Copy link
Member

@avinal avinal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, few suggestions

cmd/laas/main.go Show resolved Hide resolved
cmd/laas/main.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Please check the comments from @avinal

@k-avy k-avy changed the title feat: added two API endpoints feat: added GET endpoints Jun 26, 2023
    Get all licenses
        to get all the details of the licenses present in the database.
        gets the data of all the data components present in the database.
    Get licenses by shortname:
        to get the data of the license with the shortname passed as a parameter.
        error when no such license found.

Signed-off-by: Kavya Shukla <[email protected]>
Copy link
Contributor

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good

@ag4ums ag4ums merged commit 75aed0b into fossology:main Jun 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants