Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme patch 1 #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix readme patch 1 #2

wants to merge 2 commits into from

Conversation

TanweerulHaque
Copy link

Fixed a broken link due to a typo in "readme" file.

Please review the PR. Let me know if there should be any change. Thank you.

@SinghShreya05
Copy link
Collaborator

@TanweerulHaque

  1. remove "import preprocess" from "markov_licenses.py" file since you've removed the file and merged the functions in helper.py
  2. remove "." from file imports and update the readme about the same.

Rest all other changes are great. Everything runs on my system too without any bug. :)
Please do the necessary changes.

@SinghShreya05 SinghShreya05 mentioned this pull request Oct 10, 2021
Open
@TanweerulHaque
Copy link
Author

TanweerulHaque commented Oct 12, 2021 •
edited
Loading

Sure, I'll do the required changes. @SinghShreya05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TanweerulHaque @SinghShreya05